-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batched matrix multiplication. #1261
Merged
ClaudiaComito
merged 59 commits into
main
from
features/1104-Implement_consistent_linear_algebra_for_arrays_with_dimension_2_in_particular_matmul
Sep 9, 2024
Merged
Changes from 3 commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
67943f9
first implementation of the minimal solution
FOsterfeld 1c60823
Merge branch 'main' into features/1104-Implement_consistent_linear_al…
FOsterfeld 0ddba6c
access b.gshape[-2] only if input is not batched
FOsterfeld d60c0ca
fixed batched condition
FOsterfeld a60d3ac
throw a NotImplementedError for wrong split dimension on batched matmul
FOsterfeld e16366b
fixed dimension condition
FOsterfeld 7644dd4
added test for batched matmul with split dimension being a batch dime…
FOsterfeld 5d34282
Merge branch 'main' into features/1104-Implement_consistent_linear_al…
FOsterfeld 095ccc5
fixed condition for different batch dimensions
FOsterfeld e55f8b8
added some tests for correctly thrown errors
FOsterfeld a9ae2bf
fixed test for batched matmul on gpu
FOsterfeld 06913c7
test for batched matmul on gpu
FOsterfeld ba60c82
remove unnecessary test with device=gpu
FOsterfeld 8d95ec1
Merge branch 'main' into features/1104-Implement_consistent_linear_al…
mrfh92 1c2a939
batched matmul with split==None for both matrices
FOsterfeld a79e42d
implemented batched matmul for case split 00
FOsterfeld 980d0ec
implemented batched matmul for case split 01
FOsterfeld a44c6b2
implemented batched matmul for case split 11
FOsterfeld b506a66
cleaned up code to return the result
FOsterfeld f76e973
added tests for the batched matmul
FOsterfeld 9733a28
Merge branch 'main' into features/1104-Implement_consistent_linear_al…
mrfh92 0008a3f
Merge branch 'main' into features/1104-Implement_consistent_linear_al…
mrfh92 18cdcf1
added batched matmul tests for float values
FOsterfeld 4e49aa5
Merge branch 'main' into features/1104-Implement_consistent_linear_al…
mrfh92 bb0856b
Merge branch 'main' into features/1104-Implement_consistent_linear_al…
mrfh92 0d37ff4
Merge branch 'main' into features/1104-Implement_consistent_linear_al…
mrfh92 8531106
Merge branch 'main' into features/1104-Implement_consistent_linear_al…
mrfh92 c911e45
Merge branch 'main' into features/1104-Implement_consistent_linear_al…
mrfh92 5a2ad15
Merge branch 'main' into features/1104-Implement_consistent_linear_al…
mrfh92 e804c2c
Merge branch 'main' into features/1104-Implement_consistent_linear_al…
FOsterfeld e5ff10b
Merge branch 'main' into features/1104-Implement_consistent_linear_al…
mrfh92 da9b0e3
improved exception throwing: error message when only one matrix has s…
FOsterfeld f3e0ced
Merge branch 'main' into features/1104-Implement_consistent_linear_al…
mrfh92 2719f4d
Merge branch 'main' into features/1104-Implement_consistent_linear_al…
FOsterfeld 0f4c677
warn against the inefficient split cases in the matmul docstring
FOsterfeld 96121ee
Merge branch 'main' into features/1104-Implement_consistent_linear_al…
mrfh92 5e5eea3
Update basics.py
mrfh92 5933e48
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 0a9795f
Update basics.py
mrfh92 a2f1cc5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 816cd85
fixed style complaints
40aa455
Apply suggestions from code review
FOsterfeld ea18fa1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 2222bb7
fixed documentation
FOsterfeld 35ff132
Merge branch 'features/1104-Implement_consistent_linear_algebra_for_a…
FOsterfeld fd44be9
updated matmul tests for new batch behavior
FOsterfeld de73236
restructured code to remove code duplication of batched and unbatched…
FOsterfeld 98a4134
generalized the split case None-None to batched matrices
FOsterfeld 9e7d0f0
simplified the cases where not both matrices are split in la dimensions
FOsterfeld c95be79
generalized the None splits for batched matrices
FOsterfeld 8dffcf5
removed unnecessary import
FOsterfeld 41e203c
updated docstring
FOsterfeld 3886942
Merge branch 'main' into features/1104-Implement_consistent_linear_al…
FOsterfeld 9f9462c
Merge branch 'main' into features/1104-Implement_consistent_linear_al…
mrfh92 3f15690
Merge branch 'main' into features/1104-Implement_consistent_linear_al…
FOsterfeld ca066b2
initialize random generator
FOsterfeld 398b27e
refactored code for None splits
FOsterfeld 6f92537
Merge branch 'main' into features/1104-Implement_consistent_linear_al…
mrfh92 fc97280
Merge branch 'main' into features/1104-Implement_consistent_linear_al…
mtar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe
> 0
instead of>2
or did I understand sth wrong?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, you're right, it should be 0.