Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug-fix for lasso on GPU #1259

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

mrfh92
Copy link
Collaborator

@mrfh92 mrfh92 commented Nov 7, 2023

Bug fix for #1258
here to be merged into release; for the same bug fix to be merged into main see #1260

@ghost
Copy link

ghost commented Nov 7, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Thank you for the PR!

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee39c63) 92.17% compared to head (3d3e8e8) 92.17%.

Additional details and impacted files
@@              Coverage Diff               @@
##           release/1.3.x    #1259   +/-   ##
==============================================
  Coverage          92.17%   92.17%           
==============================================
  Files                 75       75           
  Lines              10703    10703           
==============================================
  Hits                9865     9865           
  Misses               838      838           
Flag Coverage Δ
unit 92.17% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrfh92 mrfh92 added the PR talk label Nov 10, 2023
@mrfh92 mrfh92 marked this pull request as ready for review November 20, 2023 08:19
@ClaudiaComito ClaudiaComito added this to the 1.3.1 milestone Nov 22, 2023
@ClaudiaComito ClaudiaComito added the bug Something isn't working label Nov 22, 2023
Copy link
Contributor

@ClaudiaComito ClaudiaComito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrfh92 !

Copy link
Contributor

Thank you for the PR!

@mrfh92 mrfh92 merged commit a8cebca into release/1.3.x Nov 22, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working merge queue PR talk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants