Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparse matrix (DCSR_matrix) multiplication #1251

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

Mystic-Slice
Copy link
Collaborator

Due Diligence

  • General:
    • base branch must be main for new features, latest release branch (e.g. release/1.3.x) for bug fixes
    • title of the PR is suitable to appear in the Release Notes
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • documentation updated where needed

Description

A very basic implementation of sparse matrix multiplication using torch's matmul operations.

Not efficient because the tensors are collected before the operation and then redistributed.

Still exploring more efficient parallel solutions.

Type of change

New feature

Does this change modify the behaviour of other functions? If so, which?

no

ClaudiaComito and others added 20 commits November 1, 2022 14:46
* add pr workflow

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update README.md

* Update .gitlab-ci.yml

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@ghost
Copy link

ghost commented Oct 21, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@github-actions
Copy link
Contributor

Thank you for the PR!

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 91.70%. Comparing base (5bad2ef) to head (e53df48).
Report is 240 commits behind head on main.

Files Patch % Lines
heat/sparse/linalg/basics.py 50.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1251      +/-   ##
==========================================
- Coverage   91.75%   91.70%   -0.05%     
==========================================
  Files          77       79       +2     
  Lines       11080    11094      +14     
==========================================
+ Hits        10166    10174       +8     
- Misses        914      920       +6     
Flag Coverage Δ
unit 91.70% <57.14%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This pull request is stale because it has been open for 60 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants