-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Avoid unnecessary gathering of distributed operand #1216
Merged
ClaudiaComito
merged 38 commits into
helmholtz-analytics:main
from
samadpls:features/1064-optimize-logical-functions
Feb 5, 2024
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
9d093b2
Avoid unnecessary gathering of distributed operand
samadpls 7b7a19a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f813311
updated a comment
samadpls bdf62df
refactored the logic
samadpls 0e813f1
Merge branch 'main' into features/1064-optimize-logical-functions
samadpls d32ed27
Merge branch 'main' into features/1064-optimize-logical-functions
samadpls bde9d0e
updated the `__sanitize_close_input` method
samadpls 4752d15
Merge branch 'main' into features/1064-optimize-logical-functions
ClaudiaComito 58a5c1a
Merge branch 'main' into features/1064-optimize-logical-functions
ClaudiaComito 367d25f
Merge branch 'main' into features/1064-optimize-logical-functions
samadpls 0e80601
Optimized logical operations
samadpls b5bf608
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 12c67ec
fixed typo
samadpls e875bc6
fixed the merge conflict
samadpls 0ebe1ce
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e5dc121
removed blank line after docstring
samadpls ee0714d
Merge branch 'main' into features/1064-optimize-logical-functions
samadpls e8d45d4
Fixed distributed array handling for mixed scalar and array inputs
samadpls 393b63a
Merge branch 'main' into features/1064-optimize-logical-functions
samadpls 741f1a2
Merge branch 'main' into features/1064-optimize-logical-functions
samadpls 0a4d2f2
Merge branch 'main' into features/1064-optimize-logical-functions
samadpls ae3f969
sliced the distributed array with `counts_dsipls()` method
samadpls 43e77d8
Refactor slicing operation
samadpls a354d7a
Merge branch 'main' into features/1064-optimize-logical-functions
ClaudiaComito 0b44849
Merge branch 'main' into features/1064-optimize-logical-functions
ClaudiaComito 38f4314
Update heat/core/logical.py
samadpls aa555d5
addressed the unnecessary gathering of distributed operand
samadpls 155968a
Merge branch 'main' into features/1064-optimize-logical-functions
samadpls 52cb055
refactored the `logical.py` file
samadpls 3d86a3b
Merge branch 'main' into features/1064-optimize-logical-functions
samadpls d0bf3f3
Update `heat/core/logical.py`
samadpls 60fb1cd
Refactored the `__sanitize_close_input` method
samadpls 2a4e226
Merge branch 'features/1064-optimize-logical-functions' of https://gi…
samadpls 3d1fe15
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] abbe799
Merge branch 'main' into features/1064-optimize-logical-functions
ClaudiaComito 1991a60
Merge branch 'main' into features/1064-optimize-logical-functions
mrfh92 3f1727f
Merge branch 'main' into features/1064-optimize-logical-functions
ClaudiaComito 4a2b87b
Merge branch 'main' into features/1064-optimize-logical-functions
ClaudiaComito File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're missing the same check for y distributed, x non distributed I think. Otherwise we're good to go.