Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Avoid unnecessary gathering of distributed operand #1216
Enhancement: Avoid unnecessary gathering of distributed operand #1216
Changes from 30 commits
9d093b2
7b7a19a
f813311
bdf62df
0e813f1
d32ed27
bde9d0e
4752d15
58a5c1a
367d25f
0e80601
b5bf608
12c67ec
e875bc6
0ebe1ce
e5dc121
ee0714d
e8d45d4
393b63a
741f1a2
0a4d2f2
ae3f969
43e77d8
a354d7a
0b44849
38f4314
aa555d5
155968a
52cb055
3d86a3b
d0bf3f3
60fb1cd
2a4e226
3d1fe15
abbe799
1991a60
3f1727f
4a2b87b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're missing the same check for y distributed, x non distributed I think. Otherwise we're good to go.