Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ht.concatenate() #1210

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Shoham-M
Copy link
Collaborator

Due Diligence

  • General:
    • base branch must be main for new features, latest release branch (e.g. release/1.3.x) for bug fixes
    • title of the PR is suitable to appear in the Release Notes
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • documentation updated where needed

Description

Issue/s resolved: #

Changes proposed:

Type of change

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

yes / no

@ghost
Copy link

ghost commented Aug 29, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Shoham-M Shoham-M force-pushed the features/430-Clean_up_concatenate_using_redistribute branch from b4efc85 to 4e173c4 Compare August 29, 2023 12:33
@ClaudiaComito ClaudiaComito changed the title first draft Refactor ht.concatenate() Aug 29, 2023
@Shoham-M Shoham-M marked this pull request as ready for review August 31, 2023 09:08
root and others added 3 commits August 31, 2023 12:16
* added old docstring to concatenate
* changed type conversion in concatenate from a lambda expression to proper def
@mrfh92
Copy link
Collaborator

mrfh92 commented Oct 16, 2023

What I have done:

  • resolved merge conflict with main in manipulations in favour of the new file
  • added old concatenate-docstring and changed a lambda-function into a proper def-construction in order to let pre-commit run through
  • removed test_collect from test_manipulations since collect has been removed from manipulations (I guess, because there is already a collect-function in dndarray?)

@mrfh92
Copy link
Collaborator

mrfh92 commented Oct 16, 2023

Now, it looks like that there are multiple errors for a single process (non-split arrays)

Copy link
Contributor

This pull request is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label Dec 18, 2023
@ClaudiaComito ClaudiaComito self-requested a review January 22, 2024 09:33
@ClaudiaComito
Copy link
Contributor

This should not be closed, I just assigned myself for review

@ClaudiaComito ClaudiaComito added this to the 1.5.0 milestone Apr 22, 2024
@ClaudiaComito ClaudiaComito marked this pull request as draft April 22, 2024 06:12
@ClaudiaComito ClaudiaComito self-assigned this Apr 22, 2024
@ClaudiaComito ClaudiaComito removed this from the 1.5.0 milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants