-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ht.concatenate()
#1210
Draft
Shoham-M
wants to merge
8
commits into
main
Choose a base branch
from
features/430-Clean_up_concatenate_using_redistribute
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Refactor ht.concatenate()
#1210
Shoham-M
wants to merge
8
commits into
main
from
features/430-Clean_up_concatenate_using_redistribute
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shoham-M
force-pushed
the
features/430-Clean_up_concatenate_using_redistribute
branch
from
August 29, 2023 12:33
b4efc85
to
4e173c4
Compare
for more information, see https://pre-commit.ci
* added old docstring to concatenate * changed type conversion in concatenate from a lambda expression to proper def
What I have done:
|
Now, it looks like that there are multiple errors for a single process (non-split arrays) |
This pull request is stale because it has been open for 60 days with no activity. |
This should not be closed, I just assigned myself for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due Diligence
main
for new features, latest release branch (e.g.release/1.3.x
) for bug fixesDescription
Issue/s resolved: #
Changes proposed:
Type of change
Memory requirements
Performance
Does this change modify the behaviour of other functions? If so, which?
yes / no