Binary special methods return NotImplemented #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! |
|
Thank you for the PR! |
Codecov Report
@@ Coverage Diff @@
## main #1191 +/- ##
==========================================
+ Coverage 91.75% 91.83% +0.08%
==========================================
Files 77 77
Lines 11080 11191 +111
==========================================
+ Hits 10166 10277 +111
Misses 914 914
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you for the PR! |
|
Thank you for the PR! |
|
Thank you for the PR! |
mtar
changed the title
|
Thank you for the PR! |
|
Thank you for the PR! |
|
Thank you for the PR! |
|
Thank you for the PR! |
|
Thank you for the PR! |
|
Thank you for the PR! |
ClaudiaComito
previously requested changes
Oct 30, 2023
|
Thank you for the PR! |
|
Thank you for the PR! |
mrfh92
approved these changes
Oct 30, 2023
mtar
requested review from
ClaudiaComito
and removed request for
ClaudiaComito
|
Thank you for the PR! |
mtar
dismissed
ClaudiaComito’s stale review
requested changes added, old review blocks merging
mtar
deleted the
enhancement/311-binary-arithmetic-operations-notImplemented
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due Diligence
mainfor new features, latest release branch (e.g.release/1.3.x) for bug fixesDescription
This Pull Request adds special functions for binary arithmetic operations to DNDarray, such that they return NotImplemented on unsupported inputs.
Issue/s resolved: #311, #958 (partially)
Changes proposed:
Type of change
Enhancement
Memory requirements
Performance
Does this change modify the behaviour of other functions? If so, which?
yes / no