Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create github CODEOWNERS for core maintainer HIP management #369

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gjenkins8
Copy link
Member

@gjenkins8 gjenkins8 commented Nov 10, 2024

  • make @helm/helm-org-maintainers default owner
  • allow @helm/helm-org-maintainers and @helm/helm-core-maintainers (either may approve) for hips/ dir
  • finally, ensure @helm/helm-org-maintainers remains CODEOWNERS owner

(for the CODEOWNERS to be fully valid, @helm/helm-core-maintainers needs to be added for write access; currently it does not)

Signed-off-by: George Jenkins <[email protected]>
.github/CODEOWNERS Outdated Show resolved Hide resolved
Signed-off-by: George Jenkins <[email protected]>
@gjenkins8 gjenkins8 marked this pull request as ready for review November 11, 2024 00:14
.github/CODEOWNERS Outdated Show resolved Hide resolved
Signed-off-by: George Jenkins <[email protected]>
.github/CODEOWNERS Outdated Show resolved Hide resolved
Signed-off-by: George Jenkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant