Add initial github actions #53
Conversation
jdolitsky
force-pushed
the
gh-actions
branch
4 times, most recently
from
e1640df to
d05dcb4
Compare
Signed-off-by: Josh Dolitsky <[email protected]>
Signed-off-by: Josh Dolitsky <[email protected]>
|
|
||
| # These tools appear to be in the GitHub "ubuntu-latest" environment, but not in | ||
| # the ubuntu:latest image from Docker Hub | ||
| if ! [[ -x "$(command -v curl)" || -x "$(command -v pip3)" || -x "$(command -v docker)" ]]; then |
There was a problem hiding this comment.
We now also need to install git for the clone to work.
Of course, the cloning code should be moved down below the installation of git.
| which helm || true | ||
| mkdir -p /tmp/gopath/src/helm.sh | ||
| pushd /tmp/gopath/src/helm.sh | ||
| git clone https://github.com/helm/helm.git -b dev-v3 |
There was a problem hiding this comment.
I think you can speed up the clone by adding the flags: --single-branch --depth=1
| on: | ||
| push: | ||
| branches: | ||
| - master |
There was a problem hiding this comment.
Is it possible to have multiple triggers for an action? I believe the two actions are identical except for the trigger.
There was a problem hiding this comment.
Yes, but this affects the status of the overall build. So for example, if a PR fails the "badge" on the readme would turn red. But I agree, there should be a better way to do this as to not duplicate code
|
The completion tests still fail but for a bigger problem. I haven't looked into it but once I have a moment I will. The errors are: |
|
@marckhouzam going to go ahead with the merge despite the failures, lets iterate on this from here |
Currently failing on completion tests - is this expected @marckhouzam? We can start with this and improve from here. Would rather failing CI than no CI :)
With GitHub Actions we are able to upload the Robot test report as a .zip - check out the results here (top right under "Artifacts"): https://github.com/helm/acceptance-testing/commit/b5627d491d534cb6a63002b32c0cc89770e8f76a/checks?check_suite_id=263356948
I's also like to soon address #2 (trigger CI run on helm/helm push).