-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and updates, version 0.8.28 #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like these might have been manually pulled. I'm adding here so they get included on a full rebuild.
I'm not 100% sure if this is what's desired, but I noticed that the cached version must be the old non-universal binary for 0.8.24 instead of the universal binary. When running a full rebuild, this is the hash I get.
I'm adding these because they're not part of POSIX and might not be installed in every environment.
This seems to be necessary for my system. nix hash file gives an error: path '.../bin/macos-aarch64/solc-0.8.x' is a symlink, which this change fixes.
Thank you! I am glad it's been useful for you, too. I will do a quick test run on my computer asap and merge this. Fwiw, CI currently is red, probably something trivial to fix; I will have a look later too. |
hellwolf
approved these changes
Nov 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI passes soon. Will merge momentarily. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a few things going on that I noticed while adding 0.8.28. I tried to keep each commit self contained and well described in the extended commit message, so feel free to review and exclude any for merging or leave a comment and I can rebase them out of this PR.
nix hash file ...
command didn't work for symlinks. I'm runningrealpath
on the file before hashing to ensure it always works.Thanks for putting this flake together! It's helpful for keeping up-to-date with solc versions since nixpkgs does seem to lag behind a bit.