Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and updates, version 0.8.28 #18

Merged
merged 10 commits into from
Nov 16, 2024

Conversation

benmanns
Copy link
Contributor

This PR has a few things going on that I noticed while adding 0.8.28. I tried to keep each commit self contained and well described in the extended commit message, so feel free to review and exclude any for merging or leave a comment and I can rebase them out of this PR.

  • I noticed 0.6.10 through 0.6.12 weren't in download.sh. I updated the range to include them for future full syncs.
  • My hash for 0.8.24 is different, I think because the universal binary change must have happened after downloading the aarch64 version. Do double check that modifying this doesn't cause any issues because I'm not certain the full implications of updating it.
  • I added jq and wget to the download.sh shell. I run a very minimal shell and load things in via nix and these aren't part of POSIX, so I thought it helpful to include in the nix shell since we're generating one anyways.
  • My nix hash file ... command didn't work for symlinks. I'm running realpath on the file before hashing to ensure it always works.
  • Finally, I added version 0.8.28 to the list, updated the ethereum/solc-bin/macosx-amd64/list.json revision, and updated CI.

Thanks for putting this flake together! It's helpful for keeping up-to-date with solc versions since nixpkgs does seem to lag behind a bit.

It looks like these might have been manually pulled. I'm adding here so they get included on a full rebuild.
I'm not 100% sure if this is what's desired, but I noticed that the cached version must be the old non-universal binary for 0.8.24 instead of the universal binary. When running a full rebuild, this is the hash I get.
I'm adding these because they're not part of POSIX and might not be installed in every environment.
This seems to be necessary for my system. nix hash file gives an error: path '.../bin/macos-aarch64/solc-0.8.x' is a symlink, which this change fixes.
@hellwolf
Copy link
Owner

hellwolf commented Nov 11, 2024

Thank you! I am glad it's been useful for you, too.

I will do a quick test run on my computer asap and merge this. Fwiw, CI currently is red, probably something trivial to fix; I will have a look later too.

Copy link
Owner

@hellwolf hellwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passes soon. Will merge momentarily. Thanks!

@hellwolf hellwolf merged commit 0714c24 into hellwolf:master Nov 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants