Skip to content

Commit

Permalink
bench-iai: rm iai benchmark crate
Browse files Browse the repository at this point in the history
broke recently and is rarely used
  • Loading branch information
hellux committed Jan 13, 2025
1 parent fb266a4 commit ecf5e9d
Show file tree
Hide file tree
Showing 9 changed files with 1 addition and 69 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -126,11 +126,9 @@ jobs:
- name: "Benchmark"
run: |
cargo bench -p bench-crit all > crit
cargo bench -p bench-iai > iai
- name: "Artifact results"
uses: actions/upload-artifact@v4
with:
name: benchmark
path: |
crit
iai
15 changes: 0 additions & 15 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ exclude = [
[workspace]
members = [
"bench/criterion",
"bench/iai",
"bench/input",
"examples/jotdown_wasm",
"tests/html-ref",
Expand Down
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ afl_tmin:
clean:
cargo clean
(cd tests/afl && cargo clean)
rm -rf bench/iai/target
git submodule deinit -f --all
find tests -type l -path 'tests/html-ut/ut/*.test' -print0 | xargs -0 rm -f
(cd tests/html-ut && make clean)
Expand Down
11 changes: 1 addition & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,7 @@ symlink them to the bench directory, run:
make bench
```

There are two separate benchmarks suites that can be run; criterion and iai.
Criterion measures statistical real-time performance while iai measures exact
number of executed instructions and memory accesses. To run the criterion
benchmarks, use
To run the benchmarks, use

```
cargo bench -p bench-crit [filter]
Expand All @@ -162,9 +159,3 @@ Alternatively, if `cargo-criterion` is installed:
```
cargo criterion -p bench-crit -- [filter]
```

To run the iai benchmarks, use

```
cargo bench -p bench-iai
```
14 changes: 0 additions & 14 deletions bench/iai/Cargo.toml

This file was deleted.

17 changes: 0 additions & 17 deletions bench/iai/main.rs

This file was deleted.

8 changes: 0 additions & 8 deletions contrib/bench_row.sh
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,6 @@

while getopts i:c: flag; do
case "$flag" in
i)
cargo bench -p bench-iai 2>|/dev/null \
| awk -v b="$OPTARG" '
$0 == b {inside=1}
$0 == "" {inside=0}
inside && $1 == "Estimated" {print $3, $4, $5}
'
;;
c)
# try to reduce noise by selecting max throughput of multiple runs
for _ in $(seq 100); do
Expand Down
1 change: 0 additions & 1 deletion contrib/bench_table.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ trap "git checkout $current" EXIT
OPTIND=1
while getopts i:c: flag "$@"; do
case "$flag" in
i) echo "iai:$OPTARG [cycles]";;
c) echo "criterion:$OPTARG [MB/s]";;
*) exit 1
esac
Expand Down

0 comments on commit ecf5e9d

Please sign in to comment.