Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more sane diagnostic picker column ordering #12574

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bingis-khan
Copy link

@bingis-khan bingis-khan commented Jan 17, 2025

this fixes #12571

now it looks like this:
ss-2025-01-17-13-09-41

as opposed to:
ss-2025-01-17-11-43-59

@bingis-khan bingis-khan changed the title more sane diagnostic picker column ordering more sane diagnostic picker column ordering (this fixes #12571) Jan 17, 2025
@bingis-khan
Copy link
Author

ref: #12571

@bingis-khan bingis-khan changed the title more sane diagnostic picker column ordering (this fixes #12571) more sane diagnostic picker column ordering Jan 17, 2025
@nik-rev
Copy link
Contributor

nik-rev commented Jan 17, 2025

Would be nice if it got added to the next patch release: #12560

@the-mikedavis
Copy link
Member

The current ordering is intentional: code and path are shorter than message. If code and path come after message it's unlikely you'll ever see those columns. You can use Ctrlt to hide the picker preview to see the message column.

@bingis-khan
Copy link
Author

bingis-khan commented Jan 17, 2025

The current ordering is intentional: code and path are shorter than message. If code and path come after message it's unlikely you'll ever see those columns. You can use Ctrlt to hide the picker preview to see the message column.

this makes sense only on larger screens. the "code" part is the least important part of the error message, and, as you can see, it covers most of the picker screen, even on my larger screen thinkpad and with smaller font. i, as a user, would rather press ctrl+t to get extra information (like some error code) rather than the opposite.

as you can see, error codes (at least for Haskell) are pretty long and not very descriptive and introduce extra visual noise.

fyi, on my older macbook, the situation is even worse, as the screen is smaller.

@kirawi kirawi added C-enhancement Category: Improvements A-helix-term Area: Helix term improvements S-needs-discussion Status: Needs discussion or design. and removed S-needs-discussion Status: Needs discussion or design. labels Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent update made project wide error log unreadable
4 participants