-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make language-servers spacing consistent #12565
base: master
Are you sure you want to change the base?
Conversation
Mmh, actually wait a bit, there may be an issue with this fix somehow, I need to investigate. |
Actually, I wonder if the issue is with the latest |
The languages.toml from this commit: https://github.com/helix-editor/helix/blob/99d33c741a22b69988ed60060a6a09cf2abb62be/languages.toml gives me a failed to parse error, I think it introduced an issue. |
strange, commenting line Line 1674 in 99d33c7
the languages.toml parses, with it uncommented it does not parse. I do not understand why. |
The failed CI run I believe is unrelated to the changes |
Making this spacing consistent is not desirable to me. It's falls under the category of stylistic changes which make the |
@the-mikedavis thank you for your comment :) . My feeling (but I may be wrong :) ) is that this is a bit more than style. For example, I found out this issue when trying to edit the
what happens then is that on most
(note the automatic This is the motivation for pushing this PR, rather than style per se. Of course maybe the way I was trying to add |
At present the spacing of the lsps listed in the
language-servers
fields for different languages are not consistent: see e.g.:helix/languages.toml
Line 257 in 29dda14
vs.
helix/languages.toml
Line 4049 in 29dda14
This makes "automated" editing error prone. This PR makes this spacing aspect consistent.