feat: Allow mi, ma, mr and md to use newlines
#12521
Conversation
helix-term/src/commands.rs
Outdated
|
|
||
| if let Some(ch) = event | ||
| .char() | ||
| .or((event.code == KeyCode::Enter).then_some('\n')) |
There was a problem hiding this comment.
Searching for \n is not exactly correct unless the document has LF line endings. This needs to search for doc.line_ending.as_str() instead. For a doc with CRLF line endings, selecting around \ns would exclude the opening \rs. The surround code needs to be refactored to accept &strs instead of chars in order to search for line endings
There was a problem hiding this comment.
I am going with a simpler implementation since we are dealing with line endings, I'm just using line_to_char to get information about the nth surrounding line ending. I hope that's fine
kirawi
added
C-enhancement
|
@darshanCommits It looks like you closed your PR which was going to implement replacing / deleting surrounding newlines Are you still planning on adding it? If not, I can implement it in this PR |
It was unintentional mistake on my end. I won't be able to attend it prior next week, you may go ahead and implement it here. |
nik-rev
changed the title
mi and ma to use newlinesmi, ma, mr and `md to use newlines
nik-rev
changed the title
mi, ma, mr and `md to use newlinesmi, ma, mr and md to use newlines
No description provided.