forked from rpcpool/yellowstone-grpc
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force client disconnects when node is unhealthy #13
Open
pmantica11
wants to merge
14
commits into
master-2.2
Choose a base branch
from
add-health-check-v2
base: master-2.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
7ba3d98
Intermediate commit
pmantica11 24f2685
Intermediate commit
pmantica11 2590087
Intermediate commit
pmantica11 ba6d282
Intermediate commit
pmantica11 18050ed
Nit
pmantica11 66b6447
Add health check v2
pmantica11 e551d76
Nit
pmantica11 810f25a
Nits
pmantica11 f694b55
Nit
pmantica11 4a90d24
Fix
pmantica11 a52d654
Intermediate commit
pmantica11 5bd3f39
Nits
pmantica11 b1c7beb
Improve error message
pmantica11 ceb621a
Address comments
pmantica11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
use std::{ | ||
sync::{ | ||
atomic::{AtomicBool, Ordering}, | ||
Arc, | ||
}, | ||
time::Duration, | ||
}; | ||
|
||
use once_cell::sync::Lazy; | ||
use solana_client::nonblocking::rpc_client::RpcClient; | ||
use solana_rpc_client_api::{client_error, request}; | ||
use tokio::time::interval; | ||
|
||
pub static SHOULD_DISCONNECT: Lazy<Arc<AtomicBool>> = | ||
Lazy::new(|| Arc::new(AtomicBool::new(false))); | ||
|
||
pub async fn is_node_healthy(client: &RpcClient) -> bool { | ||
loop { | ||
match client.get_health().await { | ||
Ok(()) => return true, | ||
Err(err) => { | ||
if let client_error::ErrorKind::RpcError(request::RpcError::RpcResponseError { | ||
code: _, | ||
message: _, | ||
data: request::RpcResponseErrorData::NodeUnhealthy { .. }, | ||
}) = &err.kind | ||
{ | ||
return false; | ||
} else { | ||
log::error!("Failed to get health: {}", err); | ||
tokio::time::sleep(Duration::from_secs(5)).await; | ||
continue; | ||
} | ||
} | ||
} | ||
} | ||
} | ||
|
||
pub async fn run_forced_disconnection_monitor(rpc_client: RpcClient) { | ||
let mut interval = interval(Duration::from_millis(100)); | ||
loop { | ||
interval.tick().await; | ||
let is_healthy = !is_node_healthy(&rpc_client).await; | ||
SHOULD_DISCONNECT.store(is_healthy, Ordering::SeqCst); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the master git versions was giving me package conflict errors. So I will use the latest version of the release instead. I tested the code using the Solana test validator, and it worked. So we should be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is risky, we should keep using the master versions since geyser usually has breaking changes between minor versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I retrospectively agree, but since this version has been battle tested with 2.2 and it's fixed, then I now prefer this over using the master version.