Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Add TMGIndustries maker #1189

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

haris1998-web
Copy link

@haris1998-web haris1998-web commented Jan 6, 2022

Add TMGIndustries maker

@haris1998-web
Copy link
Author

@matthewcarlreetz @cokes518 Kindly review

@cokes518
Copy link
Member

cokes518 commented Jan 6, 2022

how is this different than #1013 ?

@cokes518 cokes518 changed the title Add TMGIndustries maker [DNM] Add TMGIndustries maker Jan 6, 2022
@TMGINDUSTRIES
Copy link

this one actually has the required information ?

@haris1998-web
Copy link
Author

how is this different than #1013 ?

The previous one had no data

@cokes518
Copy link
Member

cokes518 commented Jan 6, 2022

then maybe you can close the other one?

@haris1998-web
Copy link
Author

then maybe you can close the other one?

Closed...

@TMGINDUSTRIES
Copy link

TMGINDUSTRIES commented Jan 6, 2022

its been closed thought seeing how it had no data in it that would have been checked and maybe told that i would need to close it.. sorry not all that familiar with github

import ANTENNAS from './antennas'

const TMGIndustriesHotspotBLE = {
name: 'Example Hotspot',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll need to update this placeholder.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where it says example hotspot correct ?

translations: {
en: {
diagnostic:
'<b><white>Diagnostic support allows TMG Industries Maker to identify issues with your Hotspot in a secure way.</white></b>\n\nTMG Industries Maker will never have access to private keys and will only ever be able to access your Hotspot and not any other devices on your Network.\n\nIf you would like to opt-out of diagnostic support please email <purple><b>[email protected]</b></purple> from the email used to purchase the Hotspot.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please replace the helium support email with yours

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly also guide about the id in index.ts

@haris1998-web
Copy link
Author

Updated

@TyeG1250
Copy link

hey there has this ever been completed ? all the chages you requested have been reviewed and made .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants