-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] Add TMGIndustries maker #1189
base: main
Are you sure you want to change the base?
Conversation
@matthewcarlreetz @cokes518 Kindly review |
how is this different than #1013 ? |
this one actually has the required information ? |
The previous one had no data |
then maybe you can close the other one? |
Closed... |
its been closed thought seeing how it had no data in it that would have been checked and maybe told that i would need to close it.. sorry not all that familiar with github |
src/makers/TMGIndustries/hotspots.ts
Outdated
import ANTENNAS from './antennas' | ||
|
||
const TMGIndustriesHotspotBLE = { | ||
name: 'Example Hotspot', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you'll need to update this placeholder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where it says example hotspot correct ?
src/makers/TMGIndustries/hotspots.ts
Outdated
translations: { | ||
en: { | ||
diagnostic: | ||
'<b><white>Diagnostic support allows TMG Industries Maker to identify issues with your Hotspot in a secure way.</white></b>\n\nTMG Industries Maker will never have access to private keys and will only ever be able to access your Hotspot and not any other devices on your Network.\n\nIf you would like to opt-out of diagnostic support please email <purple><b>[email protected]</b></purple> from the email used to purchase the Hotspot.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please replace the helium support email with yours
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly also guide about the id in index.ts
Updated |
hey there has this ever been completed ? all the chages you requested have been reviewed and made . |
Add TMGIndustries maker