Murisi/generic unextended checked traits #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 20, 2024
batconjurer
approved these changes
May 21, 2024
| type Output = $t; | ||
| #[inline] | ||
| fn $method(self, v: &$t) -> Option<$t> { | ||
| <$t>::$method(self, *v) |
There was a problem hiding this comment.
doesn't this force the $t to be Copy?
There was a problem hiding this comment.
I guess that assumption was already present in the existing code. I see it used below
There was a problem hiding this comment.
yeah, it's fine to assume we only care about copyable types I think
murisi
added a commit
that referenced
this pull request
May 21, 2024
sug0
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted num-traits so that the checked traits are now generic and so that they do not depend on their unchecked equivalents. Given the new use of generic, the traits are now defined for both reference and value types.