Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bind source ip #23

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hishamanver
Copy link

@hishamanver hishamanver commented Jan 11, 2024

Includes changes from #22

What

  • bind to local_ip and port when running in client mode (already done for server mode)
  • if local port is not explicitly set, then a random free port will be assigned
  • unit tests updated with new test cases

Why

When sending the INIT sctp message, we can see the following when executing the container on a Virtual Machine which has multiple interfaces
image

We have a usecase where we are attempting to run a diameter client from within a kubernetes cluster. The worker nodees have a large list of IP addresses associated with them. As a result the INIT message advertises all the ip addresses and the packet becomes too large leading to fragmentation

Before
image

After
image
reasonable size packet
(no ip address as this is not multihomed - https://www.rfc-editor.org/rfc/rfc9260.html#name-initiation-init-1)

Verification

$ python3 -m unittest tests/*.py
...................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 483 tests in 84.340s

OK

@hishamanver hishamanver marked this pull request as ready for review January 11, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant