Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📜 Improve error message when a student is in another class #5794

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

boryanagoncharenko
Copy link
Collaborator

This PR changes the error code and message for the cases in which a student in invited to class but is already added to another class. The new error code is 'student_in_another_class' and the error message is 'This student is in another class.'
Translations for English and Dutch are provided.

Fixes #5773

How to test

  1. Log in as a teacher
  2. Navigate to For Teachers > [an existing class] > Add students > Invite by username
  3. Put in the username of a student that is already enrolled in another class and check that the error message appears
  4. Click the 'Copy join link' button to get the invitation link
  5. Log in as the student that is already in another class
  6. Open the invitation link that you just copied and check that the same error message appears

Copy link
Contributor

mergify bot commented Sep 20, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f6f069d into main Sep 20, 2024
12 checks passed
Copy link
Contributor

mergify bot commented Sep 20, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the join_class_error_5773 branch September 20, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

📜 rephrase student_not_allowed_in_class?
2 participants