Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 Viewing programs shouldn't set programmers mode in editor #5775

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

jpelay
Copy link
Member

@jpelay jpelay commented Sep 13, 2024

Prevents localStorage to be modified when enforcing developers mode. This means that when going to a page like view programs, you can return to the code page and not have the programmers mode enforced on you. I also sneaked in a minor fixed regarding not showing the checkmarks on the next and previous adventure button.

Fixes #5771
How to test

  • Go to the explore page and open a program
  • Go back to the code page. Programmers mode should be disabled.

Copy link
Contributor

mergify bot commented Sep 16, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4d55bf4 into main Sep 16, 2024
12 checks passed
Copy link
Contributor

mergify bot commented Sep 16, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the independent_dev_mode branch September 16, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🪲 Programmer's mode pops up after viewing a program
2 participants