Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Setting up view program page editor #4801

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Conversation

jpelay
Copy link
Member

@jpelay jpelay commented Nov 24, 2023

Description

Sets up the editor of the view program page correctly. This is done by adding a new code parameter to the initialization of the page to set the editor contents. Also initializes the syntax highlighter.

Fixes #4796

How to test

Go to the view page of a program and it should be shown correctly.

messages.pot Outdated Show resolved Hide resolved
Copy link
Member

@Felienne Felienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature works!
image

You just need to fix a few po issues because this PR forked of of the broken main

@jpelay jpelay reopened this Nov 28, 2023
Copy link
Member

@Felienne Felienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

Copy link
Contributor

mergify bot commented Nov 28, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ef2a734 into hedyorg:main Nov 28, 2023
7 of 9 checks passed
@jpelay jpelay deleted the fix_view_page branch November 28, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Code isn't visible in program view
2 participants