Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI, FIX] adjusts hide and disables save warning popup in slides #4556

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

Felienne
Copy link
Member

@Felienne Felienne commented Sep 26, 2023

Fixes #4513. Also disables the save pop up which is quite annoying in slides mode.

As per #4363 I should not touch the front-end without supervision, so it is probably a good idea if @jpelay checks if this indeed works, and maybe to add a test for the slides and/or for raw? :D

@ghost
Copy link

ghost commented Sep 26, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@jpelay jpelay self-assigned this Sep 26, 2023
@Felienne
Copy link
Member Author

Thanks for taking a look @jpelay and making sure I don't break stuff. In the future (no rush!) it would be nice to also have cypress tests for slides.

@jpelay
Copy link
Member

jpelay commented Sep 26, 2023

Thanks for taking a look @jpelay and making sure I don't break stuff. In the future (no rush!) it would be nice to also have cypress tests for slides.

Hi, yes I was taking a look before the meeting, bit haven't fully tried it yet! Gonna review it between today/tomorrow and also maybe add some tests right away!

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 15beb17 into main Sep 27, 2023
9 checks passed
@mergify mergify bot deleted the fix-slides branch September 27, 2023 20:10
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Slides lack buttons
3 participants