Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ghc 9.12 #540

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Support ghc 9.12 #540

merged 3 commits into from
Jan 7, 2025

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Dec 4, 2024

No description provided.

@moodmosaic
Copy link
Member

@erikd, thank you! Let’s merge once CI is green.

@erikd
Copy link
Contributor Author

erikd commented Dec 4, 2024

@erikd, thank you! Let’s merge once CI is green.

We will need to wait for 9.12 to be available in the CI infrastructure.

@erikd erikd force-pushed the erikd/ghc-9.12 branch 2 times, most recently from 66e61dd to 8b7f404 Compare December 8, 2024 22:08
@erikd erikd force-pushed the erikd/ghc-9.12 branch 3 times, most recently from 30e50bf to 6223149 Compare December 19, 2024 23:12
@moodmosaic
Copy link
Member

I think this will eventually succeed once 9.12 is available in the rest of the CI.

@LaurentRDC LaurentRDC mentioned this pull request Jan 5, 2025
@LaurentRDC
Copy link

The CI action haskell/actions/setup isn't maintained anymore, hence why you won't get GHC 9.12!

Use haskell-actions/setup@v2. Here's an example for beam, where we're already testing using GHC 9.12

cabal.project Outdated Show resolved Hide resolved
@moodmosaic
Copy link
Member

moodmosaic commented Jan 5, 2025

@erikd, @LaurentRDC, any ideas how to make CI pass on the 2 failing checks?

Edit: I see #540 (comment) about haskell-actions/setup@v2 and makes sense. Yes! 👍

@erikd
Copy link
Contributor Author

erikd commented Jan 5, 2025

@erikd, @LaurentRDC, any ideas how to make CI pass on the 2 failing checks?

Edit: I see #540 (comment) about haskell-actions/setup@v2 and makes sense. Yes! 👍

Will have a look tomorrow.

@erikd erikd force-pushed the erikd/ghc-9.12 branch 2 times, most recently from d5745c5 to 22dc328 Compare January 5, 2025 21:33
@erikd
Copy link
Contributor Author

erikd commented Jan 5, 2025

Ok old CI stuff seems borked. The best way forward is probably to use haskell-ci.

@erikd erikd force-pushed the erikd/ghc-9.12 branch 2 times, most recently from 4a56cec to 9d7dad4 Compare January 5, 2025 23:03
erikd added 2 commits January 6, 2025 10:08
CI warning about potential arbitrary code execution when using
`git://...` locations.
@erikd
Copy link
Contributor Author

erikd commented Jan 5, 2025

@moodmosaic Finally got this thing passing CI 🎉

@moodmosaic
Copy link
Member

Thank you @erikd 🙌 Massive rework on CI 🛸.

Let’s merge once the hackage revision is done, most likely tomorrow.

@erikd
Copy link
Contributor Author

erikd commented Jan 6, 2025

CI rework was not a massive job. Just rename the file, add tested-with entries to all the cabal files and run haskell-cl regenerate 😀

@moodmosaic
Copy link
Member

massive diff-wise, that is. 👀👌

@moodmosaic
Copy link
Member

The new revision has been published. It will be available to users as soon as they update their package index.

Changes in this revision (hedgehog-1.5-r1):

  • Changed tested-with from

    ghc ==8.0.2: ghc ==8.2.2: ghc ==8.4.4: ghc ==8.6.5: ghc ==8.8.3: ghc ==8.10.1: ghc ==9.2.1
    to
    ghc ==8.0.2: ghc ==8.2.2: ghc ==8.4.4: ghc ==8.6.5: ghc ==8.8.3: ghc ==8.10.1: ghc ==9.2.7:
    ghc ==9.4.8: ghc ==9.6.6: ghc ==9.8.4: ghc ==9.10.1: ghc ==9.12.1

  • Changed source-repository from

    source-repository head
        type:     git
        location: git://github.com/hedgehogqa/haskell-hedgehog.git
    
    to
    source-repository head
        type:     git
        location: https://github.com/hedgehogqa/haskell-hedgehog
    

  • Changed the library component's library dependency on template-haskell from

    >=2.10 && <2.23
    to
    >=2.10 && <2.24

@moodmosaic moodmosaic merged commit 8deec00 into hedgehogqa:master Jan 7, 2025
11 checks passed
@erikd erikd deleted the erikd/ghc-9.12 branch January 7, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants