Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposes more state machine functionality. #506

Closed
wants to merge 1 commit into from

Conversation

dalaing
Copy link
Contributor

@dalaing dalaing commented Nov 12, 2023

This allows us to do fancier generation than we can do with just sequential.

I'm using this to allow for explicitly generating actions over phases - the first phase sets up some account, the second phases uses the accounts to add data to the application under test, and the third phase is reading the data.

(I'm mostly interested in using this for benchmarking, by fixing a seed and size and having some setup phases run before the actual benchmark phases)

Copy link
Member

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Can we include some example/test showing what’s possible? That’d be great to have, so the users know how to use the stuff we’re exporting.

@dalaing
Copy link
Contributor Author

dalaing commented Nov 14, 2023

For sure. I'll try to get some examples together in the next week or so.

This allows us to do fancier generation than
we can do with just `sequential`.
@dalaing
Copy link
Contributor Author

dalaing commented Dec 22, 2023

It turns out I needed more constraints inside of the Command constructor, and had to copy-and-paste huge chunks of State.hs to get my benchmarking to go. Should I close this? Or leave it in case others might need it? I can always recreate this and open a new PR if I end up with a new concrete use case for it.

@moodmosaic
Copy link
Member

Thank you for your contribution! We appreciate your effort. 🙏 💯

Regarding the PR, since it sounds like the changes might not be needed in the current scope of the project, and you're also considering different approaches, I think it would be best to close this PR for now.

Please do feel free to reopen it or submit a new PR if you find that these changes become relevant in the future or if you have other enhancements to suggest.

Thanks again for your willingness to contribute, and looking forward to any future contribution. 🚀

@dalaing dalaing closed this Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants