[WIP] Improve DVScene and initial Shadow support #20
+726
−467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's up with prefixing the parameter classes with P and D? The old naming was fine, prefixing breaks language rules throughout the library. |
|
I wanted to shorten the class names, though thinking about it now it probably will be better to just remove the "Div" prefix and replace "Parameter" with "Param". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the existing DVScene implementation with elements from https://github.com/ik-01/DiEventRangers.
Refactors the DVScene API to support multiple games by adding an argument for the user to specify which game a file originates from (there may be a way to guess the game from the data, I'll look into that).
If no game is specified during loading, it will default to the shared subset of parameters, which ensures the program doesn't crash. The game-specific parameters will then be read as Unknown, which will make loading/saving work perfectly fine, but converting between games will not be possible.