[console] Add a FieldTrait, Fix #2057 #2058
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cosmicdreams 👍 on this feature I will take a look and try to keep improving it. |
|
This is related to #2057 |
jmolivas
changed the title
|
@cosmicdreams Any plans to keep working on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obviously this needs improvement, but I wanted to share the code we worked up last night for FieldTrait. This is just a copy of FormTrait and then we tried to make it look for a list of fields instead of a list of form api definitions. We didn't finish because we need to debug this to find the right way to get that list of fields.
The hurdles ahead: