-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Composer 2 support #25
Conversation
Possible fix for #23 |
Yes please 👍 One of the Drupal plugins keeping us from using composer 2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to do do the trick.
Any idea on when this will be merged? This currently makes using drupal/console projects unusable with composer 2. Given that dev-tools like e.g. lando moved to composer2, this is rather a blocker. Is there anything I can do to get this merged? |
This is now blocking our projects, as Lando is also now on Composer 2 in its most recent release. |
Could you please merge this MR ASAP. It's required for my current project. |
@pefferen and @trackleft - er, very sorry if I tagged the wrong people here. Who can merge this? My builds are no longer working on Pantheon because this is not merged yet. |
We know this is causing compatibility issues with Pantheon's integrated composer build process. I reached out to @jmolivas, one of the original maintainers for Drupal Console, and it's on his radar. ETA by this weekend for a tagged release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tagging a new release this week |
@ossobuffo Thanks for your contribution, your PR was merged. This will be included in the next release. |
@jmolivas That's great to hear! |
@jmolivas hi, is there any updates on new tag? |
Thats great @jmolivas, but this is now blocking drupal-console, which in turn is causing blockers on just about every build system running Drupal on the planet. :) Can we get a release? |
If it helps - switching to use composer v1 makes this a minor problem. I’m not aware of anything that requires composer v2 just yet that would ever make this a blocker. There’s several options available. Composer v2 is quite new still so I can guess the testing and confidence in releasing an update can in some cases take some time. |
@driskell Composer 1 is deprecated now, and Composer 2 is way faster.. ideally this can get fixed soon |
Composer 2's PluginInterface has added two new methods. Adding stubs for these allows us to be compatible with composer-plugin-api ^2.0.