-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add black formatter and format files #283
Conversation
- scripts - pymapd - tests
553e8d7
to
7ac4b48
Compare
Does this PR just trade Black for Flake, or will it auto-format code using Black when someone submits a PR? |
@randyzwitch Black format check will be added along Flake checks and will not auto format code just like Flake. |
I'm not sure I see the value of a gigantic diff, just to switch linters. At least for Atom, there are both flake8 and Black auto-formatting plugins on save, so what do we gain by moving to Black? |
Closing this for now, fixed conftest issue. Will revisit Black once it's clearer how we can do this automatically |
Ibis has maybe it could be helpful for |
fixes #251
fixes #284