Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add black formatter and format files #283

Closed
wants to merge 5 commits into from
Closed

Add black formatter and format files #283

wants to merge 5 commits into from

Conversation

wamsiv
Copy link
Contributor

@wamsiv wamsiv commented Nov 21, 2019

fixes #251
fixes #284

@wamsiv wamsiv changed the title Wam/black Add black formatter and format files Nov 21, 2019
@wamsiv wamsiv force-pushed the wam/black branch 9 times, most recently from 553e8d7 to 7ac4b48 Compare November 22, 2019 00:29
@randyzwitch
Copy link
Contributor

Does this PR just trade Black for Flake, or will it auto-format code using Black when someone submits a PR?

@wamsiv
Copy link
Contributor Author

wamsiv commented Nov 25, 2019

@randyzwitch Black format check will be added along Flake checks and will not auto format code just like Flake.

@randyzwitch
Copy link
Contributor

I'm not sure I see the value of a gigantic diff, just to switch linters. At least for Atom, there are both flake8 and Black auto-formatting plugins on save, so what do we gain by moving to Black?

@randyzwitch
Copy link
Contributor

Closing this for now, fixed conftest issue. Will revisit Black once it's clearer how we can do this automatically

@xmnlab
Copy link
Contributor

xmnlab commented Mar 19, 2020

Ibis has black inside the git pre-commit hook and it uses also the pre-commit as a mechanism for checking inside CI. So it helps to send code in the desired format and the CI will check if the author used pre-commit. ibis has also other services inside pre-commit such as flake8 and isort.

maybe it could be helpful for pymapd now or in the future

@randyzwitch randyzwitch deleted the wam/black branch March 24, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants