Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usystem/dash: remove symlinks #126

Merged
merged 2 commits into from
Jul 25, 2024
Merged

usystem/dash: remove symlinks #126

merged 2 commits into from
Jul 25, 2024

Conversation

petershh
Copy link
Contributor

@petershh petershh commented Jul 25, 2024

Automake 1.17 got released recently, and this has broken symlinks in usystem/dash, preventing it from building successfully. These links are not required actually, so remove them.

@petershh
Copy link
Contributor Author

Hm, I guess this breaks CI since it has 1.16...

They are not needed and break builds

Signed-off-by: Peter Shkenev <[email protected]>
@petershh petershh changed the title usystem/dash: upgrade symlinks to point to automake-1.17 usystem/dash: remove symlinks Jul 25, 2024
@heatd
Copy link
Owner

heatd commented Jul 25, 2024

configure: error: cannot find required auxiliary files: compile missing install-sh

@petershh
Copy link
Contributor Author

It's from old PR version. May I ask you to restart CI?

@heatd
Copy link
Owner

heatd commented Jul 25, 2024

It's from old PR version. May I ask you to restart CI?

It's still failing, looks like it can't autogen missing, install-sh, etc after all?

Maybe the solution is to run ./autogen.sh in setup_build.sh?

@petershh
Copy link
Contributor Author

I now honestly don't know why it works for me. I've even tried to remove autoconf and automake so it couldn't take install-sh from the system, and build still worked. Will try autogen.sh though.

Also, somewhy CI checks out commit fb822ac, while mine is abd899f .

@heatd
Copy link
Owner

heatd commented Jul 25, 2024

Annoying, but LGTM I guess. And we get rid of a bunch of lines checked out on git.

@heatd heatd merged commit 7c3690e into heatd:master Jul 25, 2024
23 checks passed
@heatd
Copy link
Owner

heatd commented Jul 25, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants