Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: image search #124

Merged
merged 107 commits into from
Mar 28, 2024
Merged

feat: image search #124

merged 107 commits into from
Mar 28, 2024

Conversation

aleksasiriski
Copy link
Member

@aleksasiriski aleksasiriski commented Feb 9, 2024

Closes #119

Demo: https://feat-image-search.hearchco-frontend.pages.dev

Image search is now a category inside /search route that has a different rendering of UI

Images:

General & Images:

  • Minimum delay for loading animation (500ms)
  • New requests for additional pages / results
  • Dark theme toggle
  • Rename env from API_URL to API_URI, and added trailing / detection
  • Properly present backend errors on frontend (w/o crashing)
  • Read start/pages param from URL and put into variable

Refactor:

  • Better folder structure
  • Consistent order of imports with comments for clarity
  • Svelte formatter applied everywhere
  • Moved some code into separate files (components, functions, types)
  • Moved primary and secondary colors to tailwindcss config

@aleksasiriski aleksasiriski marked this pull request as draft February 9, 2024 13:34
@aleksasiriski aleksasiriski marked this pull request as ready for review February 21, 2024 13:44
matijakljajic

This comment was marked as resolved.

@matijakljajic matijakljajic dismissed their stale review February 27, 2024 18:13

Dismissed review as it was not intended to be approved yet.

@aleksasiriski aleksasiriski changed the title feat: Image search feat: image search Mar 1, 2024
aleksasiriski and others added 27 commits March 12, 2024 11:14
fix(search): refactor components and line clamp
* old branch (mergeability was questionable)
* load is far more simple
* added edge-case to backend
@aleksasiriski aleksasiriski merged commit fc1271c into main Mar 28, 2024
4 checks passed
@aleksasiriski aleksasiriski deleted the feat-image-search branch March 28, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Add support for Image Search
2 participants