fix(timer): stop sound on query change, bad code tho

hearchco · Jul 13, 2024 · 365f604 · 365f604
1 parent c9201dc
commit 365f604
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/lib/components/gadgets/timer/beeper.svelte b/src/lib/components/gadgets/timer/beeper.svelte
@@ -8,7 +8,7 @@
 	 */
 
 	/** @type {Props} */
-	let { beeping = $bindable(), beepingInterval = $bindable() } = $props();
+	let { beeping, beepingInterval = $bindable() } = $props();
 
 	/**
 	 * Get the frequency of a note.

diff --git a/src/lib/components/gadgets/timer/main.svelte b/src/lib/components/gadgets/timer/main.svelte
@@ -16,6 +16,12 @@
 	let beeping = $state(false);
 	/** @type {number|undefined} */
 	let beepingInterval = $state(undefined);
+	$effect(() => {
+		// Dummy IF to trigger the effect.
+		if (query) {
+		}
+		clearInterval(beepingInterval);
+	});
 
 	/** @type {HTMLElement | null} */
 	let timerNumbersContainer = $state(null);
@@ -156,7 +162,7 @@
 	}}
 />
 
-<Beeper bind:beeping bind:beepingInterval />
+<Beeper {beeping} bind:beepingInterval />
 
 <div class="mx-auto max-w-screen-sm">
 	<div class="mx-2 mt-2 border-2 border-neutral-200 dark:border-neutral-600 rounded-xl">