Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added and improved locale specification #173

Merged
merged 12 commits into from
Jan 11, 2024
Merged

feat: added and improved locale specification #173

merged 12 commits into from
Jan 11, 2024

Conversation

k4lizen
Copy link
Member

@k4lizen k4lizen commented Jan 6, 2024 •
edited
Loading

  • every getLocale-esque function now returns the URL parameter
  • added trace logs such that the whole URL sent to the engine can be seen
  • changed default format of locale to be more POSIX-like
  • added locale string validation
  • added category string validation
  • added support for these cli arguments: useragent, locale, safesearch, mobile
  • added support for these arguments as url GET/POST parameters as well
  • router now returns error page if malformed parameter is supplied

Engine specific:

  • added locale settings to bing which closes [BUG] Returned bing results low quality #172
  • added locale support to ddg
  • added safe search to etools
  • updated startpage markdown note to explain its locale
  • added safe search to yahoo
  • added locale and safesearch settings to mojeek
  • added locale and safesearch settings to brave
  • added locale validity check to qwant
  • fixed yahoo telemetry parsing which was broken by fix: url parsing #171

@k4lizen k4lizen requested a review from aleksasiriski January 6, 2024 23:37
@k4lizen k4lizen marked this pull request as draft January 6, 2024 23:45
@k4lizen k4lizen changed the title fix: improved locale determination, added request url trace logging fix: improved locale determination Jan 7, 2024
@k4lizen k4lizen changed the title fix: improved locale determination feat: improved locale determination Jan 7, 2024
@k4lizen k4lizen changed the title feat: improved locale determination feat: added and improved locale determination Jan 7, 2024
@k4lizen k4lizen changed the title feat: added and improved locale determination feat: added and improved locale specification Jan 7, 2024
@k4lizen k4lizen marked this pull request as ready for review January 7, 2024 02:36
aleksasiriski
aleksasiriski approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@aleksasiriski aleksasiriski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k4lizen k4lizen merged commit 1397928 into main Jan 11, 2024
4 checks passed
@k4lizen k4lizen deleted the fix-region branch January 11, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksasiriski aleksasiriski aleksasiriski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Returned bing results low quality
2 participants
@k4lizen @aleksasiriski