Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: Better path naming, joining with lib, env vars change for data and log #140

Merged
merged 11 commits into from
Nov 1, 2023
Merged

BREAKING CHANGE: Better path naming, joining with lib, env vars change for data and log #140

merged 11 commits into from
Nov 1, 2023

Conversation

aleksasiriski
Copy link
Member

@aleksasiriski aleksasiriski commented Oct 28, 2023 •
edited
Loading

  • Better naming of paths
  • Switch to joining paths with path.Join()
  • Env vars for data and log dirs are renamed, to represent that they are directories
  • Switch docker image to use /data instead of /config
  • Removed local.Dockerfile since it's not used
  • Fly soft limit set to 1, because it will allow for better load balancing between instances in the same location

@aleksasiriski aleksasiriski requested a review from k4lizen October 28, 2023 19:20
@aleksasiriski aleksasiriski merged commit 4fe8a11 into main Nov 1, 2023
@aleksasiriski aleksasiriski deleted the fix-data-path branch November 1, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k4lizen k4lizen k4lizen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleksasiriski @k4lizen