more sensible default sigma for MSL and GaussLik evaluators

heal-research · Jan 24, 2024 · 1db1fbc · 1db1fbc
1 parent 8080aa2
commit 1db1fbc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/include/operon/operators/evaluator.hpp b/include/operon/operators/evaluator.hpp
@@ -300,8 +300,7 @@ class OPERON_EXPORT MinimumDescriptionLengthEvaluator final : public Evaluator<D
 
 public:
     explicit MinimumDescriptionLengthEvaluator(Operon::Problem& problem, DTable const& dtable)
-        : Base(problem, dtable, sse_)
-        , sigma_(1, 1) // assume unit variance by default
+        : Base(problem, dtable, sse_), sigma_(1, 0.001)
     {
     }
 
@@ -356,7 +355,7 @@ class OPERON_EXPORT GaussianLikelihoodEvaluator final : public Evaluator<DTable>
 
     public:
     explicit GaussianLikelihoodEvaluator(Operon::Problem& problem, DTable const& dtable)
-        : Base(problem, dtable)
+        : Base(problem, dtable), sigma_(1, 0.001)
     {
     }
 

diff --git a/source/operators/evaluator.cpp b/source/operators/evaluator.cpp
@@ -71,7 +71,6 @@ namespace Operon {
         if (optimizer_ != nullptr && optimizer_->Iterations() > 0) {
             auto t0 = std::chrono::steady_clock::now();
             auto summary = optimizer_->Optimize(rng, tree);
-            // auto coefficients = opt.Optimize(targetValues, trainingRange, iter, summary);
             ResidualEvaluations += summary.FunctionEvaluations;
             JacobianEvaluations += summary.JacobianEvaluations;
             if (summary.Success) { tree.SetCoefficients(summary.FinalParameters); }