frontend: Make sidebar display the cluster name again #2930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
sniok
reviewed
Feb 20, 2025
dosubot
bot
added
size:S
The sidebar is not being updated when moving clusters. This is due to the sidebar being memoized without the cluster as a dependency. Signed-off-by: Joaquim Rocha <[email protected]>
… missing context Signed-off-by: Oleksandr Dubenko <[email protected]>
joaquimrocha
force-pushed
the
fix-sidebar-not-displaying-cluster
branch
from
a9df144 to
e90f169
Compare
sniok
approved these changes
Feb 20, 2025
skoeva
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sidebar is not being updated when moving clusters. This is due to
the sidebar being memoized without the cluster as a dependency.
How to test