frontend: global searchbar: Fix multiple clusterSettings items

[Faakhir30]

Fixes #2902

Fixed by only displaying the cluster settings page once.

[skoeva]

Pretty sure the cluster settings items are ordered alphabetically by context name, maybe keep the option related to the open context rather than just the first in the list? That probably makes the most sense here

[sniok]

I think there's a little confusion about why this is happening.
The duplicated items are not duplicated per cluster.
The reason there are two search items called "Cluster Settings" is because we have two routes with the label "Cluster Settings". Check out router.tsx:781

There's one "Cluster Settings" with path /settings
And there's another "Cluster Settings" with path /settings/cluster

The first one is an old one and just redirects to the second one.
We should only show the second "Cluster Settings" (settingsClusterHomeContext ) route in the search results.

I'd suggest filtering it out by the key settingsCluster, the same way it's done in router.tsx:977

[Faakhir30]

Thanks for the reviews,

I think there's a little confusion about why this is happening.
The duplicated items are not duplicated per cluster.

Yup verified by creating 3 clusters, it was only showing 2 cluster settings items, cluster names are being passed as params, so not considered different routes in defaultRoutes.

There's one "Cluster Settings" with path /settings
And there's another "Cluster Settings" with path /settings/cluster
The first one is an old one and just redirects to the second one.

Regarding the old path, yes I've filtered that as suggested, and now it is showing only 1 cluster setting item referencing key settingsClusterHomeContext.

[skoeva]

My apologies for the confusion, LGTM

[sniok]

looks good, thanks!

[joaquimrocha]

Thanks @Faakhir30 !