Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: refactor settings cluster #2841

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

farodin91
Copy link
Contributor

@sniok I tried to fix the issue from #2776.

@farodin91 farodin91 force-pushed the refactor-settings-cluster-fixed branch from 58c0da5 to 1843fb4 Compare February 3, 2025 21:42
@farodin91 farodin91 marked this pull request as ready for review February 4, 2025 20:11
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Feb 4, 2025
@illume illume requested a review from sniok February 5, 2025 06:58
@sniok
Copy link
Contributor

sniok commented Feb 7, 2025

hi @farodin91, I've tried this branch and it still has the same issue.

try setting 'allowed namespace' and then switching between different clusters
it overrides settings for every cluster

Recording.2025-02-07.133725.mp4

Copy link
Contributor

@sniok sniok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the effort and thanks for opening the PR but in the current state there's something broken after refactor

@farodin91
Copy link
Contributor Author

@sniok I'll check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants