Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charts: Add support for custom ingress labels #2789

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

knrt10
Copy link
Contributor

@knrt10 knrt10 commented Jan 27, 2025

  • Add ingress.labels field to allow setting custom labels on ingress resources
  • Update ingress template to merge custom labels with default labels
  • Add documentation and examples in chart README.md
  • Update test templates with latest chart version

Fixes #2779

- Add ingress.labels field to allow setting custom labels on ingress resources
- Update ingress template to merge custom labels with default labels
- Add documentation and examples in chart README.md
- Update test templates with latest chart version

Fixes #2779

Signed-off-by: Kautilya Tripathi <[email protected]>
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 27, 2025
@knrt10 knrt10 requested a review from yolossn January 27, 2025 05:33
Copy link
Contributor

@yolossn yolossn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knrt10 knrt10 merged commit db2982b into main Jan 27, 2025
10 checks passed
@knrt10 knrt10 deleted the helm-ingress-labels branch January 27, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding labels option to ingress in helm chart
2 participants