Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e-tests: headlamp.spec: Add test for pagination #1798

Merged
merged 1 commit into from
Mar 27, 2024
Merged

e2e-tests: headlamp.spec: Add test for pagination #1798

merged 1 commit into from
Mar 27, 2024

Conversation

illume
Copy link
Collaborator

@illume illume commented Mar 13, 2024 •
edited
Loading

So we can see it updates which page it is on.

@illume illume added testing e2e-tests End to end tests Table Table component issues labels Mar 13, 2024
@illume illume requested review from knrt10 and vyncent-t March 13, 2024 16:04
@illume illume self-assigned this Mar 13, 2024
knrt10
knrt10 reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@knrt10 knrt10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions. Thanks for adding these

@illume illume force-pushed the e2e-pagination-test branch 2 times, most recently from c57db6a to 2acb53d Compare March 14, 2024 15:07
@vyncent-t
Copy link
Contributor

reviewing w/ extension to test changes

@illume illume marked this pull request as draft March 14, 2024 15:11
@vyncent-t
Copy link
Contributor

reviewing w/ extension to test changes

mostly running into the timeout error, i have tried different env sets and so far only the first test of GET /plugins/list returns plugins list succeeds, the rest timeout for me in extension mode and manual test running but it could just be an error on my end

image

@illume
Copy link
Collaborator Author

illume commented Mar 14, 2024 •
edited
Loading

I'm not sure why putting these things into methods made it not pass in CI.

I will leave this for the moment, and come back to it in a couple of weeks. If someone else wants to take it over in the mean time, please feel free to do so.

@knrt10
Copy link
Contributor

knrt10 commented Mar 18, 2024

I will update the PR. Thank you for the work @illume

@knrt10 knrt10 self-assigned this Mar 18, 2024
@illume @knrt10
e2e-tests: headlamp.spec: Add test for pagination
593cb3d 
So we can see it updates which page it is on.

Signed-off-by: René Dudfield <[email protected]>
Signed-off-by: Kautilya Tripathi <[email protected]>
@knrt10 knrt10 force-pushed the e2e-pagination-test branch from 2acb53d to 593cb3d Compare March 27, 2024 05:19
@knrt10 knrt10 marked this pull request as ready for review March 27, 2024 05:20
@knrt10
Copy link
Contributor

knrt10 commented Mar 27, 2024

@illume I have updated the PR, PTAL. Thanks

@illume
Copy link
Collaborator Author

illume commented Mar 27, 2024

Thanks @knrt10

@illume illume merged commit 18ce278 into main Mar 27, 2024
5 checks passed
@illume illume deleted the e2e-pagination-test branch March 27, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knrt10 knrt10 knrt10 left review comments

@vyncent-t vyncent-t Awaiting requested review from vyncent-t

Assignees

@illume illume

@knrt10 knrt10

Labels
e2e-tests End to end tests Table Table component issues testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illume @vyncent-t @knrt10