chart: Choose whether or not to generate oidc secret #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valentin Klopfenstein <[email protected]>
Signed-off-by: Valentin Klopfenstein <[email protected]>
Signed-off-by: Valentin Klopfenstein <[email protected]>
Signed-off-by: Valentin Klopfenstein <[email protected]>
knrt10
reviewed
Jan 23, 2024
|
Thanks for the PR @ThisIsntTheWay, some minor NIT, rest LGTM. |
Signed-off-by: Valentin Klopfenstein <[email protected]>
knrt10
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Thanks for the PR @ThisIsntTheWay. Your contribution is sincerely valued and appreciated. Feel free to open more in the future🔥.
yolossn
reviewed
Jan 24, 2024
Also fix args not being passed to deployment if secret is not generated Signed-off-by: Valentin Klopfenstein <[email protected]>
yolossn
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the field
.config.oidc.createto the chartsvalues.yaml.Setting this to
falseallows the user to generate theoidcsecret themselves.By default, this value is set to
true.This would allow a user to use something like
SealedSecretsorExternalSecretto generate the secret independently, rather than having to put potentially sensitive information into the charts values.