-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: clusterActionSlice: Refactor clusterActions into a slice #1446
Conversation
1dc600c
to
e31f44e
Compare
7d98029
to
a724f7d
Compare
a724f7d
to
655a44f
Compare
53d72ab
to
42e55d2
Compare
42e55d2
to
a4b6183
Compare
Rebased against main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are sagas removed?
I have been thinking we should move request related code into sagas, to ensure they don't delay the UI.
I would like to understand how this code is analogous to what sagas provided. i.e. aren't we opening the door to a slower UI given we removed some things from sagas?
Because redux-toolkit provides a way to do async stuff now, and it seems better to remove the saga dependency and use the one the redux folks decided on.
I don't think it's slower. The requests are async and don't block the UI. |
a4b6183
to
7a386e5
Compare
Rebased against main. |
7a386e5
to
55f976f
Compare
Rebased against main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM but testing it I have noticed that the Cancel snackbar doesn't go away when I click the cancel button.
How to reproduce:
- Go to a pod, click the delete button;
- After a second or two, click the delete button in the snackbar that appears. -> That snackbar should go away and the only the one about the having been cancelled should be on for a few more secs.
@illume I think your video does show the issue. |
55f976f
to
0d75dbf
Compare
- Use new style redux toolkit, and not sagas. - Added some documentation. - Added some tests. Signed-off-by: René Dudfield <[email protected]>
0d75dbf
to
e8148a0
Compare
Thanks. I've updated it so the cancel snackbar leaves right away when the cancel button is pressed, like before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works now. LGTM.
How to test?
Part of #1159 epic.