Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple 'cluster settings' in search bar #2902

Closed
skoeva opened this issue Feb 14, 2025 · 3 comments · Fixed by #2907
Closed

Multiple 'cluster settings' in search bar #2902

skoeva opened this issue Feb 14, 2025 · 3 comments · Fixed by #2907
Labels
bug Something isn't working frontend Issues related to the frontend

Comments

@skoeva
Copy link
Contributor

skoeva commented Feb 14, 2025

Describe the bug

The search results do not have any way to distinguish which cluster the settings are for. We can either only display it once (this is probably more appropriate given the context in-cluster), or distinguish them (with the cluster name)

To Reproduce

Steps to reproduce the bug:

  1. Open a cluster in Headlamp (with multiple running clusters)
  2. Type "cluster settings" in the search bar
  3. Note how there are multiple "cluster settings" results

Image
@skoeva skoeva added bug Something isn't working frontend Issues related to the frontend labels Feb 14, 2025
@Faakhir30
Copy link
Contributor

Tried with 2 clusters, could not reproduce on my end though

Image

@skoeva
Copy link
Contributor Author

skoeva commented Feb 14, 2025

@Faakhir30 Try opening one of the clusters first, does it show up then?

@Faakhir30
Copy link
Contributor

@Faakhir30 Try opening one of the clusters first, does it show up then?

Yup, reproduced, will see this one, thanks.

Image

@Faakhir30 Faakhir30 mentioned this issue Feb 15, 2025
Merged
@github-project-automation github-project-automation bot moved this from Queued to Done in Release Plan / Roadmap Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working frontend Issues related to the frontend
Projects
Release Plan / Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

frontend: global searchbar: Fix multiple clusterSettings items Faakhir30/headlamp
2 participants
@skoeva @Faakhir30