-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create additional fields for hbz publishing catalogue #1
Create additional fields for hbz publishing catalogue #1
Conversation
I am not sure how we can reuse the DNB tags without copying them? |
1f5674f
to
8edc7ac
Compare
I'm not sure either if 517869a#diff-6ab233441d2457fd4d4370036d454637fc9ac8133b4d0226ffffa3b206391d18 will work... We should resolve the fest failures first, then try it out. What do you think? |
Disabled Qodana workflow as set in the upstream repo. See manual https://docs.github.com/de/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/disabling-and-enabling-a-workflow |
Sounds good! |
src/test/java/de/gwdg/metadataqa/marc/utils/MarcTagListerTest.java
Outdated
Show resolved
Hide resolved
Ah build log says:
|
Next test failure:
https://github.com/hbz/qa-catalogue/actions/runs/10472986275/job/29003791025#step:4:16625 @TobiasNx |
I am confused, I think I did not change anything that touches this test. But I will have another look. |
@@ -0,0 +1,91 @@ | |||
package de.gwdg.metadataqa.marc.definition.tags.hbztags; | |||
|
|||
import org.apache.hadoop.shaded.org.jline.builtins.telnet.Telnet; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it is a mistake.
It linkes the HXX elements together via ALMA MMS ID.
I added the DNB elements that are re-used in hbz again until pkiraly#507 is solved. |
@Phu2 should we merge? |
Commits 55, Files changed 110. Wow ;) Let's merge. |
Related to #6. Create tags for specific hbz catalogue.
I am not sure: