Apply suggested changes by @pkiraly

See: pkiraly#503 (comment) Co-authored-by: Peter Kiraly <[email protected]>
hbz · Aug 21, 2024 · a7eea66 · a7eea66
1 parent 06d732b
commit a7eea66
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 6 deletions.
diff --git a/src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/TagHOL.java b/src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/TagHOL.java
@@ -36,7 +36,7 @@ private void initialize() {
     setSubfieldsWithCardinality(
       "a", "Created by subfield", "R",
       "b", "Create date subfield", "R",
-      "c", "Updated by subfield",
+      "c", "Updated by subfield", "R",
       "d", "Update date subfield", "R",
       "e", "Library name subfield", "R",
       "f", "Location name subfield", "R",

diff --git a/src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/TagMNG.java b/src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/TagMNG.java
@@ -36,7 +36,7 @@ private void initialize() {
     setSubfieldsWithCardinality(
       "a", "Created by subfield", "R",
       "b", "Create date subfield", "R",
-      "c", "Updated by subfield",
+      "c", "Updated by subfield", "R",
       "d", "Update date subfield", "R",
       "e", "Suppress from publishing subfield", "R",
       "f", "Originating system subfield", "R",

diff --git a/src/test/java/de/gwdg/metadataqa/marc/analysis/bl/UseCaseTest.java b/src/test/java/de/gwdg/metadataqa/marc/analysis/bl/UseCaseTest.java
@@ -31,7 +31,7 @@ public void testPatternMatchingWithSubfield() {
     List<String> definitions = UseCase.E02.getDataElelemntsNormalized();
     assertEquals(11, definitions.size());
     assertEquals(
-      List.of("110$e", "111$e", "100$e", "700$e", "710$e", "711$e", "720$e", "751$e", "752$e", "775$e", "788$e"),
+      List.of("100$e", "110$e", "111$e", "700$e", "710$e", "711$e", "720$e", "751$e", "752$e", "775$e", "788$e"),
       definitions);
   }
 

diff --git a/src/test/java/de/gwdg/metadataqa/marc/utils/DataElementsStaticticsTest.java b/src/test/java/de/gwdg/metadataqa/marc/utils/DataElementsStaticticsTest.java
@@ -15,9 +15,9 @@ public void testStatistics() {
     assertEquals( 229, statistics.get(DataElementType.coreFields));
     assertEquals( 184, statistics.get(DataElementType.coreIndicators));
     assertEquals(2667, statistics.get(DataElementType.coreSubfields));
-    assertEquals( 262, statistics.get(DataElementType.localFields));
+    assertEquals( 264, statistics.get(DataElementType.localFields));
     assertEquals(  30, statistics.get(DataElementType.localIndicators));
-    assertEquals(2005, statistics.get(DataElementType.localSubfields));
-    assertEquals(5595, statistics.total());
+    assertEquals(2024, statistics.get(DataElementType.localSubfields));
+    assertEquals(5616, statistics.total());
   }
 }
diff --git a/src/test/java/de/gwdg/metadataqa/marc/utils/MarcTagListerTest.java b/src/test/java/de/gwdg/metadataqa/marc/utils/MarcTagListerTest.java
@@ -37,6 +37,7 @@ public void testListTag() {
       MarcVersion version = Utils.getVersion(tag);
       DataFieldDefinition definition = TagDefinitionLoader.load(
         tag.getSimpleName().replace("Tag", ""), version);
+      assertNotNull("The definition for tag " + tag.getCanonicalName() + " should not be null", definition);
       assertEquals(tag.getSimpleName() + " should have the same tag", "Tag" + definition.getTag(), tag.getSimpleName());
 
       assertEquals(version, definition.getMarcVersion());