Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publications and projects #524

Merged
merged 11 commits into from
Feb 5, 2024
Merged

Conversation

acka47
Copy link
Contributor

@acka47 acka47 commented Jan 31, 2024

  • Update gatsby starter c600a48
  • Add metadaten.community as product
  • Add end date to projects: ORCA.nrw, Alma migration and AMB
  • Add several missing presentation slides from 2023

To Do:

  • add end date for Metafacture Fix project
  • add end date to Metafacture Playground project
  • Add several missing SkoHub blog posts (last one is from July 2021)

Re. the last point: @sroertgen it probably makes sense to open a separate issue for this and maybe even write a script to create the JSON files automatically?

@acka47 acka47 requested a review from fsteeg January 31, 2024 12:33
@acka47 acka47 removed the request for review from fsteeg January 31, 2024 12:34
@acka47 acka47 marked this pull request as draft January 31, 2024 12:34
@acka47
Copy link
Contributor Author

acka47 commented Jan 31, 2024

I marked this as draft because the metadaten.community product page is not built locally. @fsteeg please take a look as I can not figure it out by myself.

@fsteeg
Copy link
Member

fsteeg commented Jan 31, 2024

I marked this as draft because the metadaten.community product page is not built locally. @fsteeg please take a look as I can not figure it out by myself.

Should be fixed with 4bd30cf.

@fsteeg fsteeg removed their assignment Jan 31, 2024
@acka47 acka47 marked this pull request as ready for review February 1, 2024 10:24
@acka47
Copy link
Contributor Author

acka47 commented Feb 1, 2024

Thanks, @fsteeg. It's ready for review now. Will you review or should I assign somebody else? However, it would be great if you could add some reasonable end dates to the fix and playground projects.

@acka47
Copy link
Contributor Author

acka47 commented Feb 1, 2024

  • Add several missing SkoHub blog posts (last one is from July 2021)

Re. the last point: @sroertgen it probably makes sense to open a separate issue for this and maybe even write a script to create the JSON files automatically?

I will open another issue for this.

@fsteeg
Copy link
Member

fsteeg commented Feb 1, 2024

Will you review or should I assign somebody else? However, it would be great if you could add some reasonable end dates to the fix and playground projects.

Yes, I'll review and add dates, then reassign to you for final review.

@fsteeg fsteeg self-requested a review February 1, 2024 11:37
@fsteeg fsteeg self-assigned this Feb 1, 2024
Copy link
Member

@fsteeg fsteeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Added start and end dates in b0adcac

Deployed to test: http://stage.lobid.org/team-de/

@fsteeg fsteeg assigned acka47 and unassigned fsteeg Feb 2, 2024
@acka47
Copy link
Contributor Author

acka47 commented Feb 5, 2024

+1 Please deploy to production. (I noticed that past projects are not listed on a person profile page. Thus might be something to add in the future.)

@fsteeg
Copy link
Member

fsteeg commented Feb 5, 2024

I noticed that past projects are not listed on a person profile page.

Now showing former projects on member pages:

http://stage.lobid.org/team/ap

@acka47
Copy link
Contributor Author

acka47 commented Feb 5, 2024

Now showing former projects on member pages:
http://stage.lobid.org/team/ap

Nice, thanks! This can definitely be deployed to production then.

@fsteeg fsteeg merged commit ff6f8a3 into master Feb 5, 2024
1 check passed
@fsteeg fsteeg deleted the updatePubsAndMetadatenCommunity branch February 5, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants