1784-useNewSigelMapping #1870
Merged
1784-useNewSigelMapping #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I created a file like this: http://test.lobid.org/organisations/search?q=_exists_%3Aisil+OR+type%3ACollection&format=csv:id,isil,sigel,name&size=25000 It only contains real sigil that are registered.
blackwinter
approved these changes
Aug 18, 2023
TobiasNx
commented
Aug 23, 2023
| @@ -266,11 +266,11 @@ | |||
| "type" : [ "Item", "PhysikalischerTitel" ], | |||
| "currentLocation" : "B4002 / UNASSIGNED", | |||
| "heldBy" : { | |||
| "id" : "http://lobid.org/organisations/DE-294-22#!", | |||
| "isil" : "DE-294-22", | |||
| "label" : "Ruhr-Universität Bochum, Verbundbibliothek IB Fachbibliothek für Geographie, Geologie, Mathematik, Psychologie" | |||
There was a problem hiding this comment.
Not sure why this is kicked out.
There was a problem hiding this comment.
Ah, the owner does not exist anymore. I could use the replacement isil instead.
|
What are the chances that this will get merged before the next indexing? |
dr0i
approved these changes
Aug 24, 2023
It's deployed right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new way for mapping sigel to isil as well as lobid-organisation-Id to label with a mapping file created like this:
http://lobid.org/organisations/search?q=_exists_%3Aisil+OR+type%3ACollection&format=csv:id,isil,sigel,name&size=25000
And transformed the file to a tsv.
With this file we kick out all sigil/isil's that are not registerd with the https://sigel.staatsbibliothek-berlin.de/
Like "DE-386-32"
Resolves #1784