Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce lookup for deprecatedUri based on mapping from zdbId #1805

Merged
merged 3 commits into from
Jun 23, 2023

Conversation

TobiasNx
Copy link
Contributor

In ALMA all zdb records loose their hbzId (aka HT Nummer). To keep at least their old record Id as deprecatedUri . I created a mapping file from the last aleph transformation and map the zdbId to the old hbzId. With this I create the deprecatedUri element.

The lookup holds 2.000.000 + key value pairs. I hope this is not to heavy on the performance.

In ALMA all zdb records loose their hbzId (aka HT Nummer). To keep at least their old record Id as deprecatedUri . I created a mapping file from the last aleph transformation and map the zdbId to the old hbzId. With this I create the deprecatedUri element.
@TobiasNx TobiasNx requested review from dr0i and fsteeg June 22, 2023 15:12
@dr0i
Copy link
Member

dr0i commented Jun 22, 2023

I think commiting a 44MB file is not good ... idk. idli. Or am I to old to consider this too much data?

I hope this is not to heavy on the performance.

Seems ok, as even the tests are ok with it . So RAM is enough (idk exactly but I think this map is loaded at whole into the memory).

@blackwinter
Copy link
Member

Would be nice if those deprecated IDs could also be searched in the union catalogue (hbzId). Then old URLs based on the hbz ID would continue to work.

@blackwinter
Copy link
Member

blackwinter commented Jun 22, 2023

I think commiting a 44MB file is not good ...

It's "only" 12 MB compressed: alma-hbz-to-zdb.tsv.gz

@TobiasNx
Copy link
Contributor Author

TobiasNx commented Jun 23, 2023

I created a gz file from my tsv and added the old hbzId to the zdb titles.

Perhaps also we could reuse the file from Jens/Verbund.

@blackwinter
Copy link
Member

added the old hbzId to the zdb titles.

Great, thanks!

@fsteeg fsteeg removed their assignment Jun 23, 2023
@dr0i dr0i merged commit 1cc6ff5 into master Jun 23, 2023
@dr0i dr0i deleted the zdbDeprecatedUriWithHbzId branch June 23, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants