Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stockNumber #1670 #1801

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Add stockNumber #1670 #1801

merged 2 commits into from
Jul 25, 2023

Conversation

TobiasNx
Copy link
Contributor

@TobiasNx TobiasNx commented Jun 20, 2023

Resolves: #1670

Please have a look.
I introduced stockNumber.

I was not sure if I should model this as an array of Objects to state the sources of the stockNumber too. Or just like this.

Copy link
Member

@blackwinter blackwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I was not sure if I should model this as an array of Objects to state the sources of the stockNumber too. Or just like this.

We're fine with either solution.

There might be use cases where $$q (Qualifying information) could be relevant, but we don't need it yet.

@blackwinter blackwinter removed their assignment Jun 20, 2023
@dr0i
Copy link
Member

dr0i commented Jun 20, 2023

Issue is missing, I don't know the context. You modelled this field at root level. Is this OK? What is the difference to callnumber (which is modelled under the item subtree)?

@dr0i dr0i assigned TobiasNx and unassigned dr0i Jun 20, 2023
@TobiasNx
Copy link
Contributor Author

Issue is missing, I don't know the context. You modelled this field at root level. Is this OK? What is the difference to callnumber (which is modelled under the item subtree)?

This #1670

@dr0i
Copy link
Member

dr0i commented Jun 20, 2023

Thx for the reference. Have you considered to put this field under publication?

@TobiasNx TobiasNx merged commit e5c86da into master Jul 25, 2023
1 check passed
@dr0i dr0i deleted the 1670-stockNumber branch May 27, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement MARC 028$$a (Publisher or Distributor Number)
4 participants