Skip to content

Commit

Permalink
Fix parameter for standardnumber token filter. (#1892)
Browse files Browse the repository at this point in the history
Losing the ISSN match without the hyphen is unfortunate, but a small price to pay when compared to the incorrect matches for hbz IDs.
  • Loading branch information
blackwinter committed Sep 19, 2023
1 parent 776d97c commit 2f45f28
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/main/resources/alma/index-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@
},
"digibib_standardnumber": {
"type": "standardnumber",
"number_types": [
"standardnumbers": [
"isbn"
]
},
Expand Down
4 changes: 2 additions & 2 deletions web/test/tests/IndexIntegrationTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,9 @@ public static Collection<Object[]> data() {
{ "q.all:(Courtillon cinéma)", /*->*/ 1 },
{ "q.all:0702075558", /*->*/ 1 },
{ "q.all:07\\-0207\\-555\\-8", /*->*/ 1 },
{ "q.all:07206763", /*->*/ 1 },
{ "q.all:07206763", /*->*/ 0 },
{ "q.all:0720\\-6763", /*->*/ 1 },
{ "q.all:HT072067630", /*->*/ 1 },
{ "q.all:HT072067630", /*->*/ 0 },

This comment has been minimized.

Copy link
@dr0i

dr0i Apr 2, 2024

Member

You mean HT07206763.

This comment has been minimized.

Copy link
@blackwinter

blackwinter Apr 2, 2024

Author Member

I'm sorry, I don't understand this comment. Can you elaborate?

This comment has been minimized.

Copy link
@dr0i

dr0i Apr 8, 2024

Member

If you would use HT07206763 it would show that the ISBN search would make a hit although a HT07206763 doesn't exist.

This comment has been minimized.

Copy link
@dr0i

dr0i Apr 8, 2024

Member

Ah ok, just saw #1916 (comment) . So no-one would query this.

This comment has been minimized.

Copy link
@blackwinter

blackwinter Apr 8, 2024

Author Member

If you would use HT07206763 it would show that the ISBN search would make a hit although a HT07206763 doesn't exist.

That doesn't matter, the plugin finds substrings that match the pattern (for ISSN in this case). And HT072067630 doesn't exist either. So the test example looks perfectly fine to me.

{ "q.all:(Erleben \\- Verstehen & Lernen)", /*->*/ 3 },
{ "q.all:(Lexicography \\: Selected Papers)", /*->*/ 1 },
{ "contribution.agent.label.digibib:Westfalen", /*->*/ 3 },
Expand Down

0 comments on commit 2f45f28

Please sign in to comment.