Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Id's String cast #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove Id's String cast #94

wants to merge 1 commit into from

Conversation

kevinresol
Copy link
Member

This is mostly a trouble maker rather than a convenient function.

  1. it subverts the type system (string is silently accepted without notice, mostly happen in refactors)
  2. it crashes if the parsing is invalid

over the past few years I only get crashes from it but never really get any benefits.

@back2dos
Copy link
Member

I think it might be there for allowing id in a query string and such.

@kevinresol
Copy link
Member Author

I think in any case it should be explicitly parsed into int (so that exceptions can be handled) before passing to tink_sql.

@grepsuzette
Copy link

grepsuzette commented Jul 27, 2020

Perhaps we could have a @:deprecated on this cast from stringly to get more visibility how often it is used.

kevinresol added a commit that referenced this pull request Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants